Hi David, Thanks for the recommendation. In future, I will add a cover letter for a long patch set. If you want, I can submit the cover letter for this patch set too.
On Thu, Feb 18, 2021 at 2:59 PM David Marchand <david.march...@redhat.com> wrote: > On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq <ibtisam.ta...@emumba.com> > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the struct option array. This > > patch get rid of all those strcmp by directly binding each longopt > > with an int enum. This is to improve readability and consistency in > > all examples. > > > > Bugzilla ID: 238 > > Cc: marko.kovace...@intel.com > > > > Reported-by: David Marchand <david.march...@redhat.com> > > Signed-off-by: Ibtisam Tariq <ibtisam.ta...@emumba.com> > > For such a series, please provide a cover letter, this is easier when > replying on the whole series (and for me when applying). > > > For the series, > Reviewed-by: David Marchand <david.march...@redhat.com> > > There are still some unaligned examples (flow_classify, ip_reassembly, > kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda, > vmdq, vmdq_dcb), but this series is a good cleanup as is for now. > > -- > David Marchand > > -- - Ibtisam
