On Thu, Mar 18, 2021 at 04:48:49PM +0100, David Marchand wrote: > On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile > <navas...@linux.microsoft.com> wrote: > > diff --git a/lib/librte_eal/common/eal_common_thread.c > > b/lib/librte_eal/common/eal_common_thread.c > > index 73a055902..5219e783e 100644 > > --- a/lib/librte_eal/common/eal_common_thread.c > > rte_thread_*et_affinity() are stable. > This breaks the ABI (which is bad) and this API change was not > announced previously. > Thank you David, I will revert the renaming of the stable functions to fix the ABI break.
Given that the original functions only operate on the current thread (using the _thread_self()), changing their names to rte_thread_self_*et_affinity() brings more clarity to the purpose of the functions. We will propose an ABI change to rename them in the next release (following the proper ABI changes procedures). > -- > David Marchand