Hi Thomas,
I will remove it from prog_guide/rte_flow.rst. Is it okay ? Thank you.
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Wednesday, April 14, 2021 5:01 PM
To: Ori Kam <[email protected]>
Cc: [email protected]; Haifei Luo <[email protected]>; Slava Ovsiienko
<[email protected]>; Raslan Darawsheh <[email protected]>;
Xueming(Steven) Li <[email protected]>; Haifei Luo <[email protected]>;
[email protected]; Xiaoyun Li <[email protected]>; Matan Azrad
<[email protected]>; Shahaf Shuler <[email protected]>; Jerin Jacob
<[email protected]>; Nithin Dabilpuram <[email protected]>; Kiran Kumar
K <[email protected]>; Ferruh Yigit <[email protected]>; Andrew
Rybchenko <[email protected]>
Subject: Re: [PATCH v4 1/3] ethdev: modify rte API for single flow dump
External email: Use caution opening links or attachments
14/04/2021 10:41, Haifei Luo:
> Previous implementations support dump all the flows. Add new arg
> rte_flow in rte_flow_dev_dump to dump one flow.
>
> Signed-off-by: Haifei Luo <[email protected]>
> Acked-by: Ajit Khaparde <[email protected]>
> Acked-by: Ori Kam <[email protected]>
[...]
> +Dump
> +~~~~~
> +
> +Dump information for all or one flows.
> +
> +.. code-block:: c
> +
> + int
> + rte_flow_dev_dump(uint16_t port_id, struct rte_flow *flow,
> + FILE *file,
> + struct rte_flow_error *error);
> +
> +Arguments:
> +
> +- ``port_id``: port identifier of Ethernet device.
> +- ``flow``: flow rule handle to dump. NULL to dump all.
> +- ``file``: a pointer to a file for output
> +- ``error``: perform verbose error reporting if not NULL. PMDs
> +initialize
> + this structure in case of error only.
> +
> +Return values:
> +
> +- 0 on success, a negative errno value otherwise and ``rte_errno`` is set.
I really don't understand why we continue duplicating rte_flow doxygen in the
guide. Please stop.
Do one good API description in doxygen,
and describe only the big picture and how-to in the guide.
