> -----Original Message----- > From: Min Hu (Connor) <[email protected]> > Sent: Wednesday, April 28, 2021 09:16 > To: Wang, Haiyue <[email protected]>; [email protected] > Cc: Yigit, Ferruh <[email protected]>; Guo, Jia <[email protected]> > Subject: Re: [PATCH] net/e1000: fix param misusage when set rte flow error > > > > 在 2021/4/27 21:22, Wang, Haiyue 写道: > >> -----Original Message----- > >> From: Min Hu (Connor) <[email protected]> > >> Sent: Tuesday, April 27, 2021 16:51 > >> To: [email protected] > >> Cc: Yigit, Ferruh <[email protected]>; Guo, Jia <[email protected]>; > >> Wang, Haiyue > >> <[email protected]> > >> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error > >> > >> This patch fixes parameter misusage when set rte flow action error. > >> > >> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > >> Cc: [email protected] > >> > >> Signed-off-by: Min Hu (Connor) <[email protected]> > >> --- > >> drivers/net/e1000/igb_flow.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > > Acked-by: Haiyue Wang <[email protected]> > > > > > >> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c > >> index 33f6b1d..e72376f 100644 > >> --- a/drivers/net/e1000/igb_flow.c > >> +++ b/drivers/net/e1000/igb_flow.c > >> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr > >> *attr, > >> memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > >> rte_flow_error_set(error, EINVAL, > >> RTE_FLOW_ERROR_TYPE_ACTION, > >> - item, "Not supported action."); > >> + act, "Not supported action."); > > > > Thanks, Connor. > > > > Just wonder how do you get this error ? With some code scan tool ? ;-) > > > No, I just read your code to help me understand flow table. I found this > part of codes are the same as others. > So I think this mistake derived from other drivers.
OK, understood. ;-) > >> return -rte_errno; > >> } > >> filter->queue = > >> -- > >> 2.7.4 > > > > . > >
