29/04/2021 17:43, Matan Azrad:
> From: Shiri Kuzin <shi...@nvidia.com>
>
> The get_ib_device_match function iterates over the list of ib devices
> returned by the get_device_list glue function and returns the ib device
> matching the provided address.
>
> Since this function is in use by several drivers, in this patch we
> share the function in common part.
>
> Signed-off-by: Shiri Kuzin <shi...@nvidia.com>
> Acked-by: Matan Azrad <ma...@nvidia.com>
> ---
> --- a/drivers/common/mlx5/linux/mlx5_common_os.c
> +++ b/drivers/common/mlx5/linux/mlx5_common_os.c
> +struct ibv_device *
> +mlx5_os_get_ib_device_match(struct rte_pci_addr *addr)
It would be better as mlx5_get_pci_ibv_device()
in drivers/common/mlx5/mlx5_common_pci.c
Just need to forward declare struct ibv_device
in drivers/common/mlx5/mlx5_common.h
This is what is done internally for sub-functions.
> --- a/drivers/common/mlx5/mlx5_common.h
> +++ b/drivers/common/mlx5/mlx5_common.h
> @@ -18,6 +18,7 @@
>
> #include "mlx5_prm.h"
> #include "mlx5_devx_cmds.h"
> +#include "mlx5_common_os.h"
>
> /* Reported driver name. */
> #define MLX5_PCI_DRIVER_NAME "mlx5_pci"
> @@ -215,6 +216,7 @@ enum mlx5_class {
> MLX5_CLASS_VDPA = RTE_BIT64(1),
> MLX5_CLASS_REGEX = RTE_BIT64(2),
> MLX5_CLASS_COMPRESS = RTE_BIT64(3),
> + MLX5_CLASS_CRYPTO = RTE_BIT64(4),
> };
This change has nothing to do in this patch I think.
> --- a/drivers/common/mlx5/version.map
> +++ b/drivers/common/mlx5/version.map
> @@ -111,6 +111,7 @@ INTERNAL {
> mlx5_os_reg_mr;
> mlx5_os_umem_reg;
> mlx5_os_umem_dereg;
> + mlx5_os_get_ib_device_match; # WINDOWS_NO_EXPORT
Please keep alphabetical order.
