> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Friday, June 18, 2021 4:58 PM
> To: Ruifeng Wang <ruifeng.w...@arm.com>; Thierry Herbelot
> <thierry.herbe...@6wind.com>
> Cc: dev@dpdk.org; jer...@marvell.com; Honnappa Nagarahalli
> <honnappa.nagaraha...@arm.com>; Juraj Linkeš
> <juraj.lin...@pantheon.tech>; nd <n...@arm.com>
> Subject: Re: [PATCH V6] config/arm: add Qualcomm Centriq 2400 part
> number
>
> 18/06/2021 10:53, Thierry Herbelot:
> > On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> > > 18/06/2021 04:09, Ruifeng Wang:
> > >> From: Thierry Herbelot <thierry.herbe...@6wind.com>
> > >>> 'part_number_config': {
> > >>> - '0xc00': {'machine_args': ['-march=armv8-a+crc']}
> > >>> + '0x800': {'machine_args': ['-march=armv8-a+crc']},
> > >>> + '0xc00': {'machine_args': ['-march=armv8-a+crc']},
> > >> Nit, redundant comma at the end of the line.
> > >
> > > What is redundant?
> >
> > The comma at the end of the second line is not necessary.
>
> It is a good practice to have comma like other lines, so no need to update
> this
> line when adding more.
>
Looked at style in the rest of the file. Just wanted them to be aligned.
I'm fine with a trailing comma at the last line.
Acked-by: Ruifeng Wang <ruifeng.w...@arm.com>
