On Mon, 22 Jun 2015 22:16:59 +0200 Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2015-06-05 15:31, Dumitrescu, Cristian: > > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > > meta-data fields. > > > Forcing aligned accesses is not really required, so this is > > > removing an unneeded constraint. > > > This issue was met during testing of the new version of the > > > ip_pipeline application. There is no performance impact. > > > This change has no ABI impact, as the previous code that uses > > > aligned accesses continues to run without any issues. > > > > > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com> > > > > Ack-ed by: Cristian Dumitrescu <cristian.dumitrescu at intel.com> > > Applied, thanks > > Cyril, feel free to fix it if it breaks with Tile arch. Also, in the code, doesn't the following break when mbuf_priv_size != 0? > #define RTE_MBUF_METADATA_UINT8_PTR(mbuf, offset) \ > (&((uint8_t *) &(mbuf)[1])[offset]) Thanks -- Cyril.
