On 9/15/2021 6:08 AM, David Marchand wrote: > Like for python, multiline statements in meson must either use a > backslash character (explicit continuation) or be enclosed in () > (implicit continuation). > > python PEP8 recommends the latter [1], and it looks like meson had > an issue with backslash before 0.50 [2]. > > 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements > 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b > > Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings") > > Reported-by: Ferruh Yigit <ferruh.yi...@intel.com> > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > config/ppc/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/config/ppc/meson.build b/config/ppc/meson.build > index 0b1948fc7c..aa1327a595 100644 > --- a/config/ppc/meson.build > +++ b/config/ppc/meson.build > @@ -20,8 +20,8 @@ endif > > # Suppress the gcc warning "note: the layout of aggregates containing > # vectors with 4-byte alignment has changed in GCC 5". > -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and > - cc.version().version_compare('<12.0') and > cc.has_argument('-Wno-psabi') > +if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and > + cc.version().version_compare('<12.0') and > cc.has_argument('-Wno-psabi')) > add_project_arguments('-Wno-psabi', language: 'c') > endif > >
Tested-by: Ferruh Yigit <ferruh.yi...@intel.com>
