+Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: > On 10/09/2021 08:36, David Marchand wrote: > > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray <m...@ashroe.eu> wrote: > >> On 09/09/2021 17:40, Rahul Shah wrote: > >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > >>> rte_port_eventdev_writer_ops symbols promoted > >>> > >>> Signed-off-by: Rahul Shah <rahul.r.s...@intel.com> > >>> --- > >>> lib/port/version.map | 8 +++----- > >>> 1 file changed, 3 insertions(+), 5 deletions(-) > >> > >> Hi Rahul, > >> > >> You need to strip the __rte_experimental attribute in the header file also. > > > > That's what I first thought... but those are variables, and there were > > not marked in the header. > > My mistake - should have checked. > > > At least, those symbols must be alphabetically sorted in version.map. > > > > About checking for experimental mark on variables... I had a patch, > > but never got it in. > > I think we should instead (forbid such exports and|insist on) rework > > API / libraries that rely on public variables. > > I'll pull together a script to identify all the variables in DPDK. > Are you expecting the rework on the port api to be done prior to 21.11?
Does it mean we should not promote these variables?
