On 10/13/21 6:20 PM, Ferruh Yigit wrote:
When 'RTE_ENABLE_ASSERT' is enabled (meson -Dc_args=-DRTE_ENABLE_ASSERT) build fails: ../drivers/net/sfc/sfc_repr.c: In function ‘sfc_repr_start’: ../drivers/net/sfc/sfc_repr.c:251:20: warning: implicit declaration of function ‘sfc_repr_lock_is_locked’; did you mean ‘rte_spinlock_is_locked’? [-Wimplicit-function-declaration] 251 | SFC_ASSERT(sfc_repr_lock_is_locked(sr)); | ^~~~~~~~~~~~~~~~~~~~~~~Fixes: c85675423f01 ("net/sfc: implement port representor start and stop") Reported-by: Raslan Darawsheh <[email protected]> Signed-off-by: Ferruh Yigit <[email protected]>
I'm sorry for the breakage. I've sent v2 which avoid usage of conditional compilation in function body. I'd prefer to fix the problem this way. Yes, it is a bit less straight-forward, but still preferable. Andrew.
