On 10/20/21 10:47 AM, Xueming(Steven) Li wrote:
> On Tue, 2021-10-19 at 20:57 +0300, Andrew Rybchenko wrote:
>> On 10/19/21 6:28 PM, Xueming Li wrote:
>>> This patch adds API to return name of device capability.
>>>
>>> Signed-off-by: Xueming Li <xuemi...@nvidia.com>
>>
>> [snip]
>>
>>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
>>> index bc55f899f72..97217529449 100644
>>> --- a/lib/ethdev/rte_ethdev.c
>>> +++ b/lib/ethdev/rte_ethdev.c
>>> @@ -165,6 +165,20 @@ static const struct {
>>>
>>> #undef RTE_TX_OFFLOAD_BIT2STR
>>>
>>> +#define RTE_ETH_DEV_CAPA_BIT2STR(_name) \
>>> + { RTE_ETH_DEV_CAPA_##_name, #_name }
>>
>> In fact, such macros make more harm than add value.
>> It complicates grep by capability name. So, it is better
>> to drop the macro and just duplicate few symbols below.
>
> Will update in next version. Eclipse resolves macros and search into
> expanded macros.
>
> BTW, do you plan to review other patches today? If so I will hold new
> version a little bit to avoid explode maillist.
Sorry, I have no time to review testpmd patches today.
ethdev part LGTM.
