Hi Jerin, > -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Wednesday, October 20, 2021 2:19 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dpdk-dev <dev@dpdk.org>; Jerin Jacob <jer...@marvell.com>; Pathak, Pravin > <pravin.pat...@intel.com>; Shetty, Rashmi <rashmi.she...@intel.com>; > pat...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 4/4] event/dlb2: optimize credit allocations > using port hint flags > > On Thu, Oct 14, 2021 at 8:22 PM Harry van Haaren > <harry.van.haa...@intel.com> wrote: > > > > From: "Pathak, Pravin" <pravin.pat...@intel.com> > > There are the following issues > > 1) WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name > mismatch: 'From: "Pathak, Pravin" <pravin.pat...@intel.com>' != > 'Signed-off-by: Pravin Pathak <pravin.pat...@intel.com>'
Signed off by line is correct, the "From" line is incorrect. > 2) > Headline too long: > event/dlb2: optimize credit allocations using port hint flags Suggest this headline (which brings under the 60 chars?) event/dlb2: optimize credit allocations with port hints > Wrong tag: > Signed-off-by: Pathak, Pravin <pravin.pat...@intel.com> > > Invalid patch(es) found - checked 4 patches > check-git-log failed > > ### event/dlb2: optimize credit allocations using port hint flags > > WARNING:TYPO_SPELLING: 'Defaut' may be misspelled - perhaps 'Default'? > #156: FILE: drivers/event/dlb2/dlb2_priv.h:27: > +#define DLB2_SW_CREDIT_QUANTA_DEFAULT 32 /* Defaut = Worker */ > ^^^^^^ > I can fix item 2 on merge. > > Regarding the author name(1). Can I change to Pravin Pathak > <pravin.pat...@intel.com> ? Yes, thanks. > Appreciate a quick reply. Thanks for review & response. <snip patch contents>
