On 10/26/2021 6:45 PM, Ananyev, Konstantin wrote:
Hi, I reworked this patch as part of a new patchset, and some comments
below.
On the comment about the offload capabilities, i.e. what happens if a
PMD supports SECURITY and TSO but not both in the same time, well, if
this is the case they should not be set both,
Ok, let' take an existing PMD: ixgbe.
It supports both IPSEC and TSO offloads.
Would IPSEC+TSO work with current ixgbe PMD?
Yes, it should work.
and also this can
theoretically happen with any offloads combinations.
Hmm... can you provide an example with any DPDK PMD when offloads
are supported in separate, but their combination doesn't?
No, I don't know any, but my point was that if we have a case where a
PMD supports TSO and IPsec but not both at the same time, then it will
be the same as with any other 2 offloads that aren't supported together.