> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Monday, November 1, 2021 5:00 PM > To: Xia, Chenbo <chenbo....@intel.com>; Vijay Srivastava > <vijay.srivast...@xilinx.com>; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava <vsriv...@xilinx.com> > Subject: Re: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver > > Hi Chenbo, > > Thanks for review. > Few questions from me below on your review notes. > > Andrew. > > On 11/1/21 11:30 AM, Xia, Chenbo wrote: > > Hi Vijay, > > > >> -----Original Message----- > >> From: Vijay Srivastava <vijay.srivast...@xilinx.com> > >> Sent: Friday, October 29, 2021 10:47 PM > >> To: dev@dpdk.org > >> Cc: maxime.coque...@redhat.com; Xia, Chenbo <chenbo....@intel.com>; > >> andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava <vsriv...@xilinx.com> > >> Subject: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver > >> > >> From: Vijay Kumar Srivastava <vsriv...@xilinx.com> > >> > >> Add new vDPA PMD to support vDPA operations of Xilinx devices. > >> This patch implements probe and remove functions. > >> > >> Signed-off-by: Vijay Kumar Srivastava <vsriv...@xilinx.com> > >> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > > > Note that your patch is not rebased on the latest commit. Reviewers > > may have trouble to review your patch. > > > > [snip] > > >> + sva->vfio_group_fd = > >> + rte_vfio_container_group_bind(sva->vfio_container_fd, > > > > DPDK allows up to 100 chars per line. Please check all code that do not > > need new lines. It will make the code look better. > > I'm sorry, but as far as I know permissive to have up to 100 chars > does not enforce to stretch all lines. Or am I missing something in > coding style? IMHO, it is still *allowed* to avoid lines longer than > 80 chars.
You are correct. 80 chars is still allowed. You can keep it if it's your preference. I just thought most people would choose 100 chars for a case above. But you can choose on your own :) /Chenbo > > [snip]
