Device iterator RTE_DEV_FOREACH() failed to return devices from
classifier like "class=vdpa", because matching name from empty kvargs
returns no result. If device name not specified in kvargs, the function
should iterate all devices.

This patch allows empty devargs or devargs without name specified.

Fixes: 6aebb942907d ("kvargs: add function to get from key and value")
Cc: olivier.m...@6wind.com

Signed-off-by: Xueming Li <xuemi...@nvidia.com>
---
21.11 specific bug, no copy to stable.org
---
 drivers/bus/auxiliary/auxiliary_params.c | 3 +++
 drivers/bus/vdev/vdev_params.c           | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/drivers/bus/auxiliary/auxiliary_params.c 
b/drivers/bus/auxiliary/auxiliary_params.c
index a9c7853ed1d..6a6382961ea 100644
--- a/drivers/bus/auxiliary/auxiliary_params.c
+++ b/drivers/bus/auxiliary/auxiliary_params.c
@@ -27,6 +27,9 @@ auxiliary_dev_match(const struct rte_device *dev,
        const struct rte_kvargs *kvlist = _kvlist;
        const char *key = auxiliary_params_keys[RTE_AUXILIARY_PARAM_NAME];
 
+       /* Iterate all devices if name not specified. */
+       if (kvlist == NULL || rte_kvargs_get(kvlist, key) == NULL)
+               return 0;
        if (rte_kvargs_get_with_value(kvlist, key, dev->name) == NULL)
                return -1;
 
diff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c
index 37d95395e7a..bab4c0d1d08 100644
--- a/drivers/bus/vdev/vdev_params.c
+++ b/drivers/bus/vdev/vdev_params.c
@@ -29,6 +29,9 @@ vdev_dev_match(const struct rte_device *dev,
        const struct rte_kvargs *kvlist = _kvlist;
        const char *key = vdev_params_keys[RTE_VDEV_PARAM_NAME];
 
+       /* Iterate all devices if name not specified. */
+       if (kvlist == NULL || rte_kvargs_get(kvlist, key) == NULL)
+               return 0;
        if (rte_kvargs_get_with_value(kvlist, key, dev->name) == NULL)
                return -1;
 
-- 
2.33.0

Reply via email to