> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, March 10, 2015 6:20 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Wodkowski, PawelX > Subject: Re: [dpdk-dev] [PATCH v6] af_packet: Fix some klocwork errors > > 2015-03-10 08:49, Ouyang, Changchun: > > From: Wodkowski, PawelX > > > > + if (kvlist != NULL) > > > > > > No need for if(). This part was fine previous patch. > > > > > > > If kvlist is NULL, no reason to call rte_kvargs_free to free it. > > So, adding this test is better. > > No, we don't need to double check. > 1/ it's already checked in rte_kvargs_free() 2/ less lines you write, better > it is >
At least 2 guys vote for removing the check, then 2 vs. 1, you win :-) Will update it in v7 Thanks for comments! Changchun