Re: [PATCH v2 7/9] vhost: remove multi-line logs

[Maxime Coquelin]

Hi Chenbo,

On 1/26/22 04:27, Xia, Chenbo wrote:

Hi Maxime,

-----Original Message-----
From: Maxime Coquelin <maxime.coque...@redhat.com>
Sent: Tuesday, January 25, 2022 7:25 PM
To: dev@dpdk.org; Xia, Chenbo <chenbo....@intel.com>;
david.march...@redhat.com
Cc: Maxime Coquelin <maxime.coque...@redhat.com>
Subject: [PATCH v2 7/9] vhost: remove multi-line logs

This patch replaces multi-lines logs in multiple single-
line logs in order to ease logs filtering based on their
socket path.

Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
---
  lib/vhost/socket.c     |  10 ++--
  lib/vhost/vhost.c      |   8 ++--
  lib/vhost/vhost_user.c | 106 +++++++++++++++++++----------------------
  3 files changed, 60 insertions(+), 64 deletions(-)

...

@@ -1122,8 +1121,7 @@ vhost_user_postcopy_region_register(struct virtio_net
*dev,

        if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER,
                                &reg_struct)) {
-               VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region "
-                               "%" PRIx64 " - %" PRIx64 " (ufd = %d) %s\n",
+               VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region %"
PRIx64 " - %" PRIx64 " (ufd = %d) %s\n",

This line is > 100 chars, and I think the original one is fine for log filtering
or using log to search code.
What do you think?

Makes sense, I will revert this change in v3.

Thanks,
Maxime