From: wangyunjian <wangyunj...@huawei.com> Sent: Thursday, February 10, 2022 8:11 PM To: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; dev@dpdk.org; us...@dpdk.org Cc: Burakov, Anatoly <anatoly.bura...@intel.com>; tho...@monjalon.net; sergio.gonzalez.mon...@intel.com; Feifei Wang <feifei.wa...@arm.com>; Ruifeng Wang <ruifeng.w...@arm.com>; Huangshaozhang <huangshaozh...@huawei.com>; dingxiaoxiong <dingxiaoxi...@huawei.com>; nd <n...@arm.com>; nd <n...@arm.com> Subject: RE: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket()
Hi, Honnappa The CPU information is as follows: Architecture: aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 128 On-line CPU(s) list: 0-127 Thread(s) per core: 1 Core(s) per socket: 64 Socket(s): 2 NUMA node(s): 4 Stepping: 0x1 L1d cache: 8 MiB L1i cache: 8 MiB L2 cache: 64 MiB L3 cache: 256 MiB NUMA node0 CPU(s): 0-31 NUMA node1 CPU(s): 32-63 NUMA node2 CPU(s): 64-95 NUMA node3 CPU(s): 96-127 I have a question, does the dpdk code implement to ensure that the memory initialization is 0? [Ruifeng] Clearing of the memory should be done by the kernel. In section 3.1.4.6 of Programmer's Guide, it says: " Hugepages are cleared by the kernel when a file in hugetlbfs or its part is mapped for the first time system-wide to prevent data leaks from previous users of the same hugepage". http://doc.dpdk.org/guides/prog_guide/env_abstraction_layer.html#memory-mapping-discovery-and-memory-reservation Thanks, Yunjian From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] Sent: Wednesday, February 9, 2022 2:05 AM To: wangyunjian <wangyunj...@huawei.com<mailto:wangyunj...@huawei.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; us...@dpdk.org<mailto:us...@dpdk.org> Cc: Feifei Wang <feifei.wa...@arm.com<mailto:feifei.wa...@arm.com>>; Ruifeng Wang <ruifeng.w...@arm.com<mailto:ruifeng.w...@arm.com>>; Huangshaozhang <huangshaozh...@huawei.com<mailto:huangshaozh...@huawei.com>>; dingxiaoxiong <dingxiaoxi...@huawei.com<mailto:dingxiaoxi...@huawei.com>>; nd <n...@arm.com<mailto:n...@arm.com>>; nd <n...@arm.com<mailto:n...@arm.com>> Subject: RE: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket() Hi Yunjian, This is not a synchronization problem. The memory is getting allocated and used in the same thread. Are you using a single socket system? Thanks, Honnappa From: wangyunjian <wangyunj...@huawei.com<mailto:wangyunj...@huawei.com>> Sent: Tuesday, February 8, 2022 2:01 AM To: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com<mailto:honnappa.nagaraha...@arm.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; us...@dpdk.org<mailto:us...@dpdk.org> Cc: Feifei Wang <feifei.wa...@arm.com<mailto:feifei.wa...@arm.com>>; Ruifeng Wang <ruifeng.w...@arm.com<mailto:ruifeng.w...@arm.com>>; Huangshaozhang <huangshaozh...@huawei.com<mailto:huangshaozh...@huawei.com>>; dingxiaoxiong <dingxiaoxi...@huawei.com<mailto:dingxiaoxi...@huawei.com>>; nd <n...@arm.com<mailto:n...@arm.com>> Subject: RE: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket() There is also a condition that the hugepagesz is 1G. If the hugepagesz is 2M, this problem cannot be repeated. Thanks, Yunjian From: wangyunjian Sent: Monday, February 7, 2022 10:44 AM To: 'Honnappa Nagarahalli' <honnappa.nagaraha...@arm.com<mailto:honnappa.nagaraha...@arm.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; us...@dpdk.org<mailto:us...@dpdk.org> Cc: Feifei Wang <feifei.wa...@arm.com<mailto:feifei.wa...@arm.com>>; Ruifeng Wang <ruifeng.w...@arm.com<mailto:ruifeng.w...@arm.com>>; Huangshaozhang <huangshaozh...@huawei.com<mailto:huangshaozh...@huawei.com>>; dingxiaoxiong <dingxiaoxi...@huawei.com<mailto:dingxiaoxi...@huawei.com>>; nd <n...@arm.com<mailto:n...@arm.com>> Subject: RE: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket() Hi, Honnappa This problem is probability. Test case need to be executed multiple times. The test steps and code are as follows: /home/dpdk #./arm64-armv8a-linuxapp-gcc/app/dpdk-testpmd --legacy-mem -c 0xC -m 8192 app/test-pmd/testpmd.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 55eb293cc0..3c127f9623 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -4251,6 +4251,20 @@ main(int argc, char** argv) rte_stats_bitrate_reg(bitrate_data); } #endif + + printf("start test rte_zmalloc_socket\n"); + char *a; + while((a = rte_zmalloc_socket(NULL, 1024 * 1024, 0, SOCKET_ID_ANY)) != NULL) { + for (int i = 0; i < 1024 * 1024; i++) { + if (a[i] != 0) { + printf("a[%d] = %d\n",i,a[i]); + } + a[i] = 255; // This assignment is important. It can increase the probability. + } + } + printf("end test rte_zmalloc_socket\n"); + return EXIT_SUCCESS; + #ifdef RTE_LIB_CMDLINE if (strlen(cmdline_filename) != 0) cmdline_read_from_file(cmdline_filename); Thanks, Yunjian From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] Sent: Monday, January 31, 2022 12:22 PM To: wangyunjian <wangyunj...@huawei.com<mailto:wangyunj...@huawei.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; us...@dpdk.org<mailto:us...@dpdk.org> Cc: Feifei Wang <feifei.wa...@arm.com<mailto:feifei.wa...@arm.com>>; Ruifeng Wang <ruifeng.w...@arm.com<mailto:ruifeng.w...@arm.com>>; Huangshaozhang <huangshaozh...@huawei.com<mailto:huangshaozh...@huawei.com>>; dingxiaoxiong <dingxiaoxi...@huawei.com<mailto:dingxiaoxi...@huawei.com>>; Honnappa Nagarahalli <honnappa.nagaraha...@arm.com<mailto:honnappa.nagaraha...@arm.com>>; nd <n...@arm.com<mailto:n...@arm.com>> Subject: RE: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket() Hi Yunjian, That's interesting. Is it possible to elaborate the use case or possibly provide the code snippet? It is possible that it is a synchronization problem due to relaxed memory model that Arm architecture uses. There could be a barrier missing in the code. Thanks, Honnappa From: wangyunjian <wangyunj...@huawei.com<mailto:wangyunj...@huawei.com>> Sent: Saturday, January 29, 2022 9:21 PM To: dev@dpdk.org<mailto:dev@dpdk.org>; us...@dpdk.org<mailto:us...@dpdk.org> Cc: Feifei Wang <feifei.wa...@arm.com<mailto:feifei.wa...@arm.com>>; Ruifeng Wang <ruifeng.w...@arm.com<mailto:ruifeng.w...@arm.com>>; Huangshaozhang <huangshaozh...@huawei.com<mailto:huangshaozh...@huawei.com>>; dingxiaoxiong <dingxiaoxi...@huawei.com<mailto:dingxiaoxi...@huawei.com>> Subject: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket() Hi, all There's a problem that the memory are allocated by rte_zmalloc_socket() may not be all-zero on the ARM platform. However, the x86 platform does not have this problem. Any ideas ? Thanks, Yunjian
