[PATCH 13/20] net/ice: fix memory leaks in error handlings

[Weiguo Li]

The function release 'pkt_buf' and 'msk_buf' when successful. In some
error handlings, 'pkt_buf' and 'msk_buf' were not freed leads to memory
leaks.
To fix it without introducing code redundancy, add and make use of an
'error' lable to do the clean ups for 'pkt_buf' and 'msk_buf'.

Fixes: 1b9c68120a1c50 ("net/ice: enable protocol agnostic flow offloading in 
RSS")

Signed-off-by: Weiguo Li <liw...@foxmail.com>
---
 drivers/net/ice/ice_hash.c | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index afbb357fa3..aed256d57c 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -658,7 +658,7 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad,
        uint8_t spec_len, pkt_len;
        uint8_t tmp_val = 0;
        uint8_t tmp_c = 0;
-       int i, j;
+       int i, j, ret = 0;
 
        raw_spec = item->spec;
        raw_mask = item->mask;
@@ -675,9 +675,10 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad,
                return -ENOMEM;
 
        msk_buf = rte_zmalloc(NULL, pkt_len, 0);
-       if (!msk_buf)
-               return -ENOMEM;
-
+       if (!msk_buf) {
+               ret = -ENOMEM;
+               goto exit;
+       }
        /* convert string to int array */
        for (i = 0, j = 0; i < spec_len; i += 2, j++) {
                tmp_c = raw_spec->pattern[i];
@@ -713,21 +714,28 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad,
                        msk_buf[j] = tmp_val * 16 + tmp_c - '0';
        }
 
-       if (ice_parser_create(&ad->hw, &psr))
-               return -rte_errno;
-       if (ice_parser_run(psr, pkt_buf, pkt_len, &rslt))
-               return -rte_errno;
+       if (ice_parser_create(&ad->hw, &psr)) {
+               ret = -rte_errno;
+               goto exit;
+       }
+       if (ice_parser_run(psr, pkt_buf, pkt_len, &rslt)) {
+               ret = -rte_errno;
+               goto exit;
+       }
        ice_parser_destroy(psr);
 
        if (ice_parser_profile_init(&rslt, pkt_buf, msk_buf,
-               pkt_len, ICE_BLK_RSS, true, &prof))
-               return -rte_errno;
+               pkt_len, ICE_BLK_RSS, true, &prof)) {
+               ret = -rte_errno;
+               goto exit;
+       }
 
        rte_memcpy(&meta->raw.prof, &prof, sizeof(prof));
 
+exit:
        rte_free(pkt_buf);
        rte_free(msk_buf);
-       return 0;
+       return ret;
 }
 
 static void
-- 
2.25.1