14/04/2022 15:14, Thomas Monjalon:
> 11/04/2022 05:55, Huichao Cai:
> > According to RFC791,the options may appear or not in datagrams.
> > They must be implemented by all IP modules (host and gateways).
> > What is optional is their transmission in any particular datagram,
> > not their implementation.So we have to deal with it during the
> > fragmenting process.Add some test data for the IPv4 header optional
> > field fragmenting.
> > 
> > Signed-off-by: Huichao Cai <chcch...@163.com>
> 
> You forgot the ack given on v5:
> Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> 
> Applied, thanks.

No sorry, it cannot be applied as-is.

Some IP constants should be defined in lib/net/rte_ip.h
and should be named RTE_IPV4_HDR_OPT_* for consistency.


Reply via email to