> On Wed, Apr 27, 2022 at 5:22 PM Pavan Nikhilesh > <pbhagavat...@marvell.com> wrote: > > > > Split x86 and SW hash crc intrinsics into a separate files. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > > You still need to keep those headers public. > Otherwise, this breaks compilation for external applications relying > on rte_hash_crc.h. > > Example: > $ ./devtools/test-meson-builds.sh > > [snip] > > ## Building l3fwd > In file included from l3fwd_em.c:37: > /home/dmarchan/builds/main/build-x86- > generic/install/usr/local/include/rte_hash_crc.h:24:10: > fatal error: hash_crc_sw.h: No such file or directory > 24 | #include <hash_crc_sw.h> > | ^~~~~~~~~~~~~~~ > compilation terminated. > gmake: *** [Makefile:41: build/l3fwd-shared] Error 1
I will include them under indirect_headers with rte prefix in the next version. Thanks, Pavan. > > > -- > David Marchand
