On Thu, Jun 02, 2022 at 10:52:25PM +0200, Thomas Monjalon wrote: > 01/06/2022 13:15, Stanislaw Kardach: > > All other rte_lpm_lookup* functions take lpm argument as a const. As the > > basic rte_lpm_lookup() performs the same function, it should also do > > that. > > > > As this function is inline, no API/ABI change happens. > > It is an API change and should be noted in the release notes. > > > static inline int > > -rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > > +rte_lpm_lookup(const struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > While I've no particular objection to it appearing in the RN doc, I wonder whether it really counts as an API change. I can't see any practical difference that this change would make to the end user - no source code needs updating for example.
/Bruce
