Hi, I've submitted a patch on 27th May, 2022. One of the tests is failing and I think it is not related to the patch. Following test is failing: - ci/github-robot: build
Can you please rerun the tests so that the patch can be submitted. Regards, -Usman On Fri, May 27, 2022 at 11:42 AM Usman Tanveer <usman.tanv...@emumba.com> wrote: > > There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() > due to which user gets misleading message upon first open/start call. > It says that the > device is already stopped, which should not be the case. This patch > removes rte_eth_dev_stop() from rte_ethtool_net_open(). > > Signed-off-by: Usman Tanveer <usman.tanv...@emumba.com> > --- > examples/ethtool/lib/rte_ethtool.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/examples/ethtool/lib/rte_ethtool.c > b/examples/ethtool/lib/rte_ethtool.c > index ffaad96498..0a000d0a7b 100644 > --- a/examples/ethtool/lib/rte_ethtool.c > +++ b/examples/ethtool/lib/rte_ethtool.c > @@ -297,12 +297,6 @@ rte_ethtool_set_pauseparam(uint16_t port_id, > int > rte_ethtool_net_open(uint16_t port_id) > { > - int ret; > - > - ret = rte_eth_dev_stop(port_id); > - if (ret != 0) > - return ret; > - > return rte_eth_dev_start(port_id); > } > > -- > 2.25.1 >