On Thu, Jun 9, 2022 at 8:50 PM Sathesh B Edara <sed...@marvell.com> wrote: > > Updated ethdev ops support for link_update(), > stats_get() and stats_reset()
a) Split as two patches (Suggested heading) 1) net/octeontx_ep: support basic stats 2) net/octeontx_ep: support link status b) Update doc/guides/nics/features/octeontx_ep.ini See doc/guides/nics/features.rst > > Signed-off-by: Sathesh B Edara <sed...@marvell.com> Since this is your first path, you may consider changing to "Sathesh Edara <sed...@marvell.com>" > +static int > +otx_ep_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) > +{ > + struct rte_eth_link link; > + > + RTE_SET_USED(wait_to_complete); > + > + if (!eth_dev->data->dev_started) > + return 0; > + > + link.link_speed = RTE_ETH_SPEED_NUM_10G; Isn't this RTE_ETH_SPEED_NUM_NONE? as its speed is "Not defined" >