> From: Stephen Hemminger <step...@networkplumber.org> > Sent: Wednesday, June 8, 2022 3:14 AM > [...] > This change needs additional changes to make it correct English > grammar.
Thank you for the useful comments to this and other patches. I hope you don't mind that I took some sentences almost verbatim for v2. > [...] > > +This PMD does not require physical addresses, > > +so capability configuration is not needed to access hugepages. > > In technical writing "therefore" is preferred over "so" > and you need a preposition. Please reword something like: > > "This PMD does can operate without direct physical memory and > hugepages > are not required." > > Often applications will keep using hugepages (makes them NIC > independent) > and in that case they would still need permissions. MLX5 PMD uses hugepages but does not use physical addresses unlike most other HW drivers. I tried to make it more clear in v2.
