> From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Monday, June 20, 2022 11:38 AM > [...] > > > > +For ``virtio`` PMD in legacy mode, ``SYS_RAWIO`` capability is > > > required > > > > +for ``iopl()`` call to enable access to PCI IO ports. > > > > > > > > > > How "legacy" is legacy-mode? Is it still likely in widespread use > that > > > we need this? > > > > I don't really know. > > The spec says that legacy support is optional > > (2.2.3 Legacy Interface: A Note on Feature Bits) and it aims > > to reduce the chance of a legacy driver attempting to drive the > device > > (4.1.2.1 Device Requirements: PCI Device Discovery). > > OTOH, DPDK supports it and requirements must be documented. > > I can add a line suggesting to use modern virtio, > > but also don't mind removing this. > > > > I suppose the main question for this legacy virtio bit > is where it should be documented, more than if it should be. > Given this is a GSG, we should try and avoid getting too deep > into driver-specific issues, so I think we should omit legacy virtio here, > but have it docuemented in the relevant virtio-specific doc. > Does that seem reasonable?
Yes, moved to the virtio doc (it looks like it could use an update BTW). I also chose to keep HPET line because there's an entire section on HPET below in the document.