> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Monday, June 27, 2022 5:27 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo <chenbo....@intel.com>; > sta...@dpdk.org; Yuanhan Liu <yuanhan....@linux.intel.com>; Jens Freimann > <jfreim...@redhat.com> > Subject: [PATCH 1/4] vhost: add some trailing newline in log messages > > VHOST_LOG_* macros don't append a newline. > Add missing ones. > > Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") > Fixes: af1475918124 ("vhost: introduce API to start a specific driver") > Fixes: 2dfeebe26546 ("vhost: check return of mutex initialization") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > lib/vhost/socket.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c > index 7a0f63af14..24d60ca149 100644 > --- a/lib/vhost/socket.c > +++ b/lib/vhost/socket.c > @@ -499,7 +499,7 @@ vhost_user_reconnect_init(void) > > ret = pthread_mutex_init(&reconn_list.mutex, NULL); > if (ret < 0) { > - VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex", > __func__); > + VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex\n", > __func__); > return ret; > } > TAILQ_INIT(&reconn_list.head); > @@ -507,9 +507,9 @@ vhost_user_reconnect_init(void) > ret = rte_ctrl_thread_create(&reconn_tid, "vhost_reconn", NULL, > vhost_user_client_reconnect, NULL); > if (ret != 0) { > - VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread"); > + VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread\n"); > if (pthread_mutex_destroy(&reconn_list.mutex)) > - VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect > mutex", __func__); > + VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect > mutex\n", __func__); > } > > return ret; > @@ -1170,8 +1170,8 @@ rte_vhost_driver_start(const char *path) > "vhost-events", NULL, fdset_event_dispatch, > &vhost_user.fdset); > if (ret != 0) { > - VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset > handling thread", path); > - > + VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset > handling thread\n", > + path); > fdset_pipe_uninit(&vhost_user.fdset); > return -1; > } > -- > 2.36.1
Reviewed-by: Chenbo Xia <chenbo....@intel.com>