> Subject: Re: [PATCH 13/17] net/mana: add function to start/stop RX queues > > On Fri, 1 Jul 2022 02:02:43 -0700 > lon...@linuxonhyperv.com wrote: > > > + > > +static uint8_t > mana_rss_hash_key_default[TOEPLITZ_HASH_KEY_SIZE_IN_BYTES] = { > > + 0x2c, 0xc6, 0x81, 0xd1, > > + 0x5b, 0xdb, 0xf4, 0xf7, > > + 0xfc, 0xa2, 0x83, 0x19, > > + 0xdb, 0x1a, 0x3e, 0x94, > > + 0x6b, 0x9e, 0x38, 0xd9, > > + 0x2c, 0x9c, 0x03, 0xd1, > > + 0xad, 0x99, 0x44, 0xa7, > > + 0xd9, 0x56, 0x3d, 0x59, > > + 0x06, 0x3c, 0x25, 0xf3, > > + 0xfc, 0x1f, 0xdc, 0x2a, > > +}; > > + > > Is this constant?
I found it awkward defining it as const. Later, the code uses ".rx_hash_key = mana_rss_hash_key_default" to assign this to the IB verb interface. rx_hash_key is of type uint8_t * (non const). I'm yet to find a way to do this assignment without the compiler complaining about convert const pointer to pointer.