> -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Monday 11 July 2022 17:37 > To: Kearney, Tadhg <tadhg.kear...@intel.com> > Cc: dev@dpdk.org; dave.h...@intel.com; Burakov, Anatoly > <anatoly.bura...@intel.com>; Pattan, Reshma <reshma.pat...@intel.com> > Subject: Re: [PATCH v1 1/4] power: add uncore api to power library > > On Mon, 11 Jul 2022 16:22:57 +0000 > tadhgkearney <tadhg.kear...@intel.com> wrote: > > > + FILE *f_cur_min; /**< FD of scaling_min */ > > + FILE *f_cur_max; /**< FD of scaling_max */ > > + FILE *f_base_min; /**< FD of initial min */ > > + FILE *f_base_max; /**< FD of initial max */ > > Do you need to hold these extra FD's open? > Also wasteful to use stdio for simple control sysfs like this.
Hi Stephen, No these extra FD's don't need to be kept open, will remove their usage for v3. What do you mean exactly by using stdio; are you suggesting to not make use of flush() calls, or more broadly avoid stdio altogether? Thanks, Tadhg
