Thomas, thank you! - Helin
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, May 19, 2015 6:33 PM > To: Zhang, Helin > Cc: dev at dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang > > 2015-05-18 16:43, Bruce Richardson: > > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote: > > > Compile warnings on ICC and clang can be found, and treated as > errors. > > > Disabling those warnings forcedly can fix them. > > > > > > v2 changes: > > > Added the fix for the compile error on clang. > > > > > > v3 changes: > > > Reworded the commit titles. > > > > Series Acked-by: Bruce Richardson <bruce.richardson at intel.com> > > Applied, thanks > I reworded the commit message and added reference to the breaking > commit: > http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf > Please consider giving this kind of explanation when fixing things, > especially for special handling of base drivers.