23/09/2022 10:49, David Marchand: > On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger > <step...@networkplumber.org> wrote: > > > For now, I'll post a v2, extending the series to other internal objects. > > > We can conclude on this topic during 22.11. > > > > If you get chance to deconstruct API, switching to a numeric index > > is safest similar to what Tyler suggested. Think of ethdev port number > > and Posix file descriptor model. The advantage of an index is that > > it can be validated more easily by the code that is called. > > This is still a heavy change in the APIs. > The deprecation notice did not mention such change, and I don't think > many people are aware of this suggestion. > This would need more discussion but I don't want to block the series > on concluding on this question. > > So I am for going ahead with the series in its current form.
I agree that changing the object type would too much heavy. The goal of this series is to hide the object, not changing the way we refer to it. I understand the compilation check is stronger on a plain object than on a pointer, but I don't think this benefit is worth changing some basic API of DPDK. It seems our users prefer having less API change.
