Hi Reshma Many thanks for your review. On 2022/9/23 17:22, Pattan, Reshma wrote:
-----Original Message----- From: Dongdong Liu <liudongdo...@huawei.com> Subject: [PATCH v3 2/7] app/procinfo: add firmware version dump Add support for dump ethdev firmware version. The command is like: dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- --firmware-version Signed-off-by: Min Hu (Connor) <humi...@huawei.com> Signed-off-by: Dongdong Liu <liudongdo...@huawei.com>+ if (rte_eth_dev_fw_version_get(i, fw_version, + ETHDEV_FWVERS_LEN) == 0) + printf("Ethdev port %u firmware version: %s\n", i, + fw_version); + else + printf("Ethdev port %u firmware version: %s\n", i, + "not available");Small question, do you want to show generic msg "Not available" ? instead of different printing messages based on what is returned from the " rte_eth_dev_fw_version_get" .
Tt is ok to show generic msg "Not available". Thanks, Dongdong
Acked-by: Reshma Pattan <reshma.pat...@intel.com> .
