On 2022-10-06 10:39, David Marchand wrote: > On Thu, Oct 6, 2022 at 10:28 AM Harry van Haaren > <harry.van.haa...@intel.com> wrote: >> >> This commit extends the timeout for service_may_be_active() >> from 100ms to 1000ms. Local testing on a idle and loaded system >> (compiling DPDK with all cores) always completes after 1 ms. >> >> The wait time for a service-lcore to finish is also extended >> from 100ms to 1000ms. >> >> The same timeout waiting code was duplicated in two tests, and >> is now refactored to a standalone function avoiding duplication. >> >> Reported-by: David Marchand <david.march...@redhat.com> >> Suggested-by: Mattias Ronnblom <mattias.ronnb...@ericsson.com> >> Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > Just to be sure, do we want such a timeout in the test logic itself?
I think it depends on how quickly you want to produce a failure, and also if there are some follow-up tests in the same autotest that you want to proceed with, regardless of the outcome. > Is it that you want to make sure that the synchronisation happens in a > "reasonable" (subject to discussion ;-)) amount of time? > > Otherwise, the unit tests run in the CI are themselves subject to a > 10s x mutiplier timeout (-t meson test option). > And then I would rely on this overall timeout. > >
