On 10/18/2022 12:26 PM, Chaoyong He wrote:
The cpp bridge service is needed for some debug tools, and should be optional, so remove the mandatory requirement of service lcore parameter.
I assume cpp is 'Command Push Pull', if so please describe it in the commit log (unless it is a common abbreviation),
like "The CPP (Command Pull Push) bridge ..." Also in patch title please use abbreviations as upper case, like: net/nfp: fix CPP bridge service requirement
Fixes: b18804219537 ("net/nfp: add initial flower firmware support") Signed-off-by: Chaoyong He <chaoyong...@corigine.com> --- drivers/net/nfp/nfp_ethdev.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index f11a1b6..b105edb 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1066,11 +1066,8 @@/* register the CPP bridge service here for primary use */ret = nfp_enable_cpp_service(pf_dev->cpp); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Enable cpp service failed."); - ret = -EINVAL; - goto hwqueues_cleanup; - } + if (ret != 0) + PMD_INIT_LOG(INFO, "Enable cpp service failed.");
