> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 7 February 2023 09.47 > > The doc string was left to its previous definition. Make it explicit > that RTE_TEL_INT_VAL is a 64-bit signed integer. > > Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API") > > Signed-off-by: Robin Jarry <rja...@redhat.com> > --- > lib/telemetry/rte_telemetry.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/telemetry/rte_telemetry.h > b/lib/telemetry/rte_telemetry.h > index ad712732be04..d8ea97f17395 100644 > --- a/lib/telemetry/rte_telemetry.h > +++ b/lib/telemetry/rte_telemetry.h > @@ -43,7 +43,7 @@ struct rte_tel_data; > */ > enum rte_tel_value_type { > RTE_TEL_STRING_VAL, /** a string value */ > - RTE_TEL_INT_VAL, /** a signed 32-bit int value */ > + RTE_TEL_INT_VAL, /** a signed 64-bit int value */ > RTE_TEL_UINT_VAL, /** an unsigned 64-bit int value */ > RTE_TEL_CONTAINER, /** a container struct */ > }; > -- > 2.39.1 >
Yes, this value type has changed as the comment reflects. We could consider adding a note that the value does not exceed 32-bit when using API version 23, because the "set" functions in API version 23 only take a 32-bit value parameter. But such a note will be purely informative, and would probably add more confusion than information. Reviewed-by: Morten Brørup <m...@smartsharesystems.com>
