If a telemetry endpoint callback returns 0 without modifying the data
object, output_json() may be called with undefined contents in data.
This can cause crashes and/or worse (double free, etc.).
Reset data before passing it to the endpoint callbacks.
Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
Cc: [email protected]
Signed-off-by: Robin Jarry <[email protected]>
---
lib/telemetry/telemetry.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 655191bcf17f..6303429bb0c9 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -335,6 +335,8 @@ perform_command(telemetry_cb fn, const char *cmd, const
char *param, int s)
{
struct rte_tel_data data;
+ memset(&data, 0, sizeof(data));
+
int ret = fn(cmd, param, &data);
if (ret < 0) {
char out_buf[MAX_CMD_LEN + 10];
--
2.39.1
