> -----Original Message----- > From: N?lio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com] > Sent: Thursday, November 5, 2015 4:51 PM > To: Mcnamara, John; Olivier Matz; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size > to 512 > > On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote: > > Increase commandline buffer size to 512 to allow for longer > > commandlines required by testpmd when dealing with flow director and > > IPv6 addresses. > > > > ... > > > > /* configuration */ > > -#define RDLINE_BUF_SIZE 256 > > +#define RDLINE_BUF_SIZE 512 > > > > I have faced the same issue. For some commands this value is still too > low. For example, RETA update can not be used, the command line limits > he configuration to 34 entries. > > See http://dpdk.org/ml/archives/dev/2015-October/024681.html > and particularly > http://dpdk.org/ml/archives/dev/2015-October/024682.html > > It was too late to announce an ABI change so we left out the cmdline > size update. > > Olivier, Thomas, what do you think about this? It seems this is really > blocking.
Hi, Since the change breaks ABI I'll self nack. However, this is something that should be fixed since it will affect any DPDK application with a long commandline. I can put a warning of future ABI breakage in the release notes but I see that there are other #defines that you need to increase in your patchset so do you want to submit the ABI deprecation notice? John. --
