在 2023/2/9 11:23, fengchengwen 写道:
Acked-by: Chengwen Feng <fengcheng...@huawei.com> And, how abort add error log in telemetry valid_name, so so that problems can be identified as early as possible.
It might be better for adding an error log. What do you think, Bruce?
On 2023/2/9 11:03, Huisong Li wrote:The telemetry lib has added a allowed characters set for dictionary names, See commit 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") The space is not in this set, which cause the heap ID in /eal/heap_info cannot be displayed. Additionally, 'heap' is also misspelling. So use 'Heap_id' to replace 'Head id'. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li <lihuis...@huawei.com> --- lib/eal/common/eal_common_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index c917b981bc..c2a4c8f9e7 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params, malloc_heap_get_stats(heap, &sock_stats);rte_tel_data_start_dict(d);- rte_tel_data_add_dict_uint(d, "Head id", heap_id); + rte_tel_data_add_dict_uint(d, "Heap_id", heap_id); rte_tel_data_add_dict_string(d, "Name", heap->name); rte_tel_data_add_dict_uint(d, "Heap_size", sock_stats.heap_totalsz_bytes);.
