Hi folks,
Any chance to look at this commit? Any other feedback before I push V6? (will
remove extra line there below in the commit)
-----Original Message-----
From: Sevincer, Abdullah <abdullah.sevin...@intel.com>
Sent: Sunday, February 12, 2023 11:44 AM
To: Stephen Hemminger <step...@networkplumber.org>
Cc: dev@dpdk.org; jer...@marvell.com
Subject: RE: [PATCH v3] app/procinfo: display eventdev xstats for PMD data
Thanks Stephen,
I will remove extra line there.
Instead malloc using of calloc is required or just suggestion?
I can see allocation is done in same way with malloc in
lib\eventdev\rte_eventdev.c (reference to eventdev_build_telemetry_data
function).
I will keep malloc as it is if there is no opposition.
Thanks,
Abdullah.
-----Original Message-----
From: Stephen Hemminger <step...@networkplumber.org>
Sent: Monday, February 6, 2023 4:22 PM
To: Sevincer, Abdullah <abdullah.sevin...@intel.com>
Cc: dev@dpdk.org; jer...@marvell.com
Subject: Re: [PATCH v3] app/procinfo: display eventdev xstats for PMD data
On Mon, 6 Feb 2023 17:05:05 -0600
Abdullah Sevincer <abdullah.sevin...@intel.com> wrote:
> +
> + size = (unsigned int)ret; /* number of names */
> +
> + /* Get memory to hold stat names, IDs, and values */
> +
> + xstats_names = malloc(sizeof(struct rte_event_dev_xstats_name) * size);
> + ids = malloc(sizeof(unsigned int) * size);
> +
> +
> + if (!xstats_names || !ids)
> + rte_panic("unable to alloc memory for stats retrieval\n");
You might want to use calloc() here.
Seems like lots of extra blank lines.
