Re: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build

[Akihiko Odaki]

On 2023/04/20 16:20, Ruifeng Wang wrote:
-----Original Message-----
From: Akihiko Odaki <akihiko.od...@daynix.com>
Sent: Friday, April 14, 2023 8:42 PM
To: Ruifeng Wang <ruifeng.w...@arm.com>; Bruce Richardson 
<bruce.richard...@intel.com>
Cc: dev@dpdk.org; Akihiko Odaki <akihiko.od...@daynix.com>
Subject: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build
We enable NUMA even if the presence of NUMA is unknown for the other 
architectures. Enable
NUMA for generic Arm build too.

Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
  config/arm/meson.build | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build index 
724c00ad7e..f8ee7cdafb
100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -271,13 +271,15 @@ implementers = {
  soc_generic = {
      'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
      'implementer': 'generic',
-    'part_number': 'generic'
+    'part_number': 'generic',
+    'numa': true

The default value of numa is true. So no need to add it here?

if not soc_config.get('numa', true)
     has_libnuma = 0
endif

You're right. I confirmed this change is unnecessary. Please ignore this 
patch and consider merging only the first patch of this series.


  }

  soc_generic_aarch32 = {
      'description': 'Generic un-optimized build for armv8 aarch32 exec mode',
      'implementer': 'generic',
-    'part_number': 'generic_aarch32'
+    'part_number': 'generic_aarch32',
+    'numa': true
  }

  soc_armada = {
--
2.40.0