On Tue, Jun 20, 2023 at 8:56 AM Jerin Jacob <jerinjac...@gmail.com> wrote: > > On Tue, Jun 20, 2023 at 2:17 AM David Marchand > <david.march...@redhat.com> wrote: > > > > Allow disabling of the graph library in builds. > > Good to make graph as optional. > I did not check the build, will examples/l3fwd-graph/ skip automatically ?
Yes. Each example exposes its required dependencies. examples/meson.build will skip any example with unmet requirements unless the example was explicitly set in the -Dexamples= list of examples to build. See: https://git.dpdk.org/dpdk/tree/examples/meson.build#n105 https://git.dpdk.org/dpdk/tree/examples/meson.build#n79 https://git.dpdk.org/dpdk/tree/examples/meson.build#n117 > > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > +if dpdk_conf.has('RTE_LIB_GRAPH') > > Can devtools/test-meson-builds.sh updated to check build with > disabling all optional libs? I already tested this series with our script: we already have a "mini" target. build build-mini cc skipABI $use_shared -Ddisable_libs=* \ -Denable_drivers=net/null ... Message: Skipping example "l2fwd-jobstats" Library rt found: YES Message: Missing dependency "graph" for example "l3fwd-graph" Message: Skipping example "l3fwd-graph" Message: Missing dependency "power" for example "l3fwd-power" Message: Skipping example "l3fwd-power" ... -- David Marchand
