On 2/9/2023 6:36 AM, Chengwen Feng wrote:
This patch supports memarea test of rte_memarea_create() and
rte_memarea_destroy() API.
Signed-off-by: Chengwen Feng <[email protected]>
Reviewed-by: Dongdong Liu <[email protected]>
Acked-by: Morten Brørup <[email protected]>
---
Hi,
+
+static int
+test_memarea(void)
+{
+ test_memarea_prepare();
+
+ MEMAREA_TEST_API_RUN(test_memarea_create_bad_param);
+ MEMAREA_TEST_API_RUN(test_memarea_create_destroy);
It looks a lot like you're reimplementing functionality that is already
present in the test app, as we already have infrastructure to support
test setup, teardown, and running different test suites (see e.g.
fbarray or EAL flags tests for example). Is there any particular reason
why you didn't go for this approach?
--
Thanks,
Anatoly
