> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Thursday, August 17, 2023 3:18 PM > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheert...@intel.com>; > Carrillo, Erik G <erik.g.carri...@intel.com>; Gujjar, Abhinandan S > <abhinandan.guj...@intel.com>; McDaniel, Timothy > <timothy.mcdan...@intel.com>; Pavan Nikhilesh > <pbhagavat...@marvell.com>; Shijith Thotton <sthot...@marvell.com>; > Hemant Agrawal <hemant.agra...@nxp.com>; Sachin Saxena > <sachin.sax...@oss.nxp.com>; Van Haaren, Harry > <harry.van.haa...@intel.com>; mattias.ronnblom > <mattias.ronnb...@ericsson.com>; Liang Ma <lian...@liangbit.com>; > Mccarthy, Peter <peter.mccar...@intel.com> > Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API > > On Thu, Aug 17, 2023 at 3:06 PM Naga Harish K, S V > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Jerin Jacob <jerinjac...@gmail.com> > > > Sent: Thursday, August 17, 2023 2:27 PM > > > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > > > Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheert...@intel.com>; > > > Carrillo, Erik G <erik.g.carri...@intel.com>; Gujjar, Abhinandan S > > > <abhinandan.guj...@intel.com>; McDaniel, Timothy > > > <timothy.mcdan...@intel.com>; Pavan Nikhilesh > > > <pbhagavat...@marvell.com>; Shijith Thotton <sthot...@marvell.com>; > > > Hemant Agrawal <hemant.agra...@nxp.com>; Sachin Saxena > > > <sachin.sax...@oss.nxp.com>; Van Haaren, Harry > > > <harry.van.haa...@intel.com>; mattias.ronnblom > > > <mattias.ronnb...@ericsson.com>; Liang Ma <lian...@liangbit.com>; > > > Mccarthy, Peter <peter.mccar...@intel.com> > > > Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API > > > > > > On Thu, Aug 17, 2023 at 11:33 AM Naga Harish K S V > > > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" > > > > for creating Rx adapter instance. This API is similar to > > > > rte_event_eth_rx_adapter_create_ext() with an additional input > > > > argument for adapter configuration parameters of type "struct > > > > rte_event_eth_rx_adapter_params". > > > > > > > > Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com> > > > > > > > + */ > > > > +__rte_experimental > > > > +int __rte_cold > > > > > > Is there any specific reason to keep __rte_cold here? None of the > > > other libraries has this. > > > > __rte_cold is a hint function in the cold path. It is used for code > > optimization purposes and many net PMDs are using this. > > I understand that, the question was more on what is the significance of that > for this specific API ? > There are a lot of slow path APIs in evendev and all other library none of > them use it. > It just put into different section of binary and optimize more for size. I > think, > there is no specific reason to add this ONLY for this API to make it standout. >
Removed __rte_cold attribute for this API to be in sync with other eventdev library APIs. The updated patch is posted in V3. > Also, The cold attribute is not implemented in GCC versions earlier than 4.3. > > > > > > > > > Rest looks good to me. > > > > > > For library changes, please keep all evendev maintainers in Cc. I > > > have added those now for this email. > > > > > > > > > > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, > > > > +uint8_t > > > dev_id, > > > > + rte_event_eth_rx_adapter_conf_cb conf_cb, > > > > + void *conf_arg, > > > > + struct rte_event_eth_rx_adapter_params > > > > +*rxa_params);
