On 11/25/2023 1:47 AM, Huisong Li wrote: > Add link up/down feature for features.rst. > > Fixes: 915e67837586 ("ethdev: API for link up and down") > Cc: sta...@dpdk.org >
Documentation is added after feature, so above fixes line is not correct. I am not sure if this is fix, I think more like it is extending the document. With fixes line fix, Acked-by: Ferruh Yigit <ferruh.yi...@amd.com> > Signed-off-by: Huisong Li <lihuis...@huawei.com> > Acked-by: Chengwen Feng <fengcheng...@huawei.com> > --- > doc/guides/nics/features.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 0d38c5c525..f14962a6c3 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -45,6 +45,10 @@ Supports getting the link speed, duplex mode and link > state (up/down). > * **[implements] rte_eth_dev_data**: ``dev_link``. > * **[related] API**: ``rte_eth_link_get()``, > ``rte_eth_link_get_nowait()``. > > +Set link up/down an Ethernet device. > + > +* **[implements] eth_dev_ops**: ``dev_set_link_up``, ``dev_set_link_down``. > +* **[related] API**: ``rte_eth_dev_set_link_up()``, > ``rte_eth_dev_set_link_down()``. > > .. _nic_features_link_status_event: >