> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Wednesday, December 6, 2023 2:34 AM
> To: Joyce Kong <[email protected]>
> Cc: Jakub Grajciar <[email protected]>; Morten Brørup
> <[email protected]>; Ruifeng Wang <[email protected]>;
> [email protected]; nd <[email protected]>; [email protected]; Liangxing Wang
> <[email protected]>
> Subject: Re: [PATCH v1] net/memif: fix segfault with Tx burst larger than 255
> 
> On Tue,  5 Dec 2023 04:05:24 +0000
> Joyce Kong <[email protected]> wrote:
> 
> > There will be a segfault when tx burst size is larger than 256. This
> > is because eth_memif_tx uses an index i which is uint8_t to count
> > transmitted nb_pkts. Extend i to uint16_t, the same size as nb_pkts.
> >
> > Fixes: b5613c8f9d0a ("net/memif: add a Tx fast path")
> > Cc: [email protected]
> >
> > Reported-by: Liangxing Wang <[email protected]>
> > Signed-off-by: Joyce Kong <[email protected]>
> > Reviewed-by: Ruifeng Wang <[email protected]>
> > ---
> 
> I wonder if other drivers have same bug?

I don't think this is a common bug.
This is a special case as the bug is introduced for whether choosing the memif 
Tx fast path. 

> 
> Reviewed-by: Stephen Hemminger <[email protected]>

Reply via email to