Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit <[email protected]> > Sent: Friday, January 19, 2024 2:59 PM > To: Sivaramakrishnan, VenkatX <[email protected]>; > Hemant Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi > <[email protected]>; Chaoyong He <[email protected]>; > Gagandeep Singh <[email protected]>; Jerin Jacob <[email protected]>; > Maciej Czekaj <[email protected]> > Cc: [email protected]; Power, Ciara <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list > > On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote: > > Address Sanitizer detects a buffer overflow caused by an incorrect > > ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. > > Fix the ptypes list for drivers. > > > > Fixes: 0849ac3b6122 ("net/tap: add packet type management") > > Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing") > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") > > Fixes: f3f0d77db6b0 ("net/mrvl: support packet type parsing") > > Fixes: 71e8bb65046e ("net/nfp: update supported list of packet types") > > Fixes: 659b494d3d88 ("net/pfe: add packet types and basic statistics") > > Fixes: 398a1be14168 ("net/thunderx: remove generic passX references") > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > > > Signed-off-by: Sivaramakrishnan Venkat > > <[email protected]> > > > > Reviewed-by: Ferruh Yigit <[email protected]> > > > ("Cc: <email>" shouldn't be in the commit message, but not big deal I can > remove them while merging. > If you want to help, in next version please put them after '---', as you are > already doing with changelog)
Thanks for the review on this one. The DPDK docs suggest adding the Fixes line + CC in the commit message body - has the guidelines changed for this? We can update in the next version if that is preferred here though, no problem. Thanks, Ciara
