On 10/19/2015 1:07 PM, Xie, Huawei wrote: > On 10/19/2015 12:20 PM, Stephen Hemminger wrote: > > On Sun, 18 Oct 2015 14:28:59 +0800 > Huawei Xie <huawei.xie at intel.com><mailto:huawei.xie at intel.com> wrote: > > > > + if (vq->sw_ring) > + rte_free(vq->sw_ring); > + > > > > Do not need to test for NULL before calling rte_free. > Better to just rely on the fact that rte_free(NULL) is documented > to be ok (no operation). > > > > ok, btw, in previous commit, just in the same function, > void virtio_dev_queue_release(vq) > [...] > > rte_free(vq); > > vq = NULL; > I think there is no need to set NULL to vq. Will submit a patch to fix it if > you agree. In v3 patch, i also remove the "vq = NULL". > >
- [dpdk-dev] [PATCH 6/8] virtio: virtio vec rx Huawei Xie
- [dpdk-dev] [PATCH 7/8] virtio: simple tx routine Huawei Xie
- [dpdk-dev] [PATCH 8/8] virtio: rxtx_func_get Huawei Xie
- [dpdk-dev] [PATCH 0/8] virtio: virtio ring layout optimi... Xie, Huawei
- [dpdk-dev] [PATCH v2 0/7] virtio ring layout optimizatio... Huawei Xie
- [dpdk-dev] [PATCH v2 0/7] virtio ring layout optimizatio... Huawei Xie
- [dpdk-dev] [PATCH v2 1/7] virtio: add virtio_rxtx.h... Huawei Xie
- [dpdk-dev] [PATCH v2 2/7] virtio: add software rx r... Huawei Xie
- [dpdk-dev] [PATCH v2 2/7] virtio: add software ... Stephen Hemminger
- [dpdk-dev] [PATCH v2 2/7] virtio: add softw... Xie, Huawei
- [dpdk-dev] [PATCH v2 2/7] virtio: add s... Xie, Huawei
- [dpdk-dev] [PATCH v2 3/7] virtio: rx/tx ring layout... Huawei Xie
- [dpdk-dev] [PATCH v2 4/7] virtio: fill RX avail rin... Huawei Xie
- [dpdk-dev] [PATCH v2 5/7] virtio: virtio vec rx Huawei Xie
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx routine Huawei Xie
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx rou... Stephen Hemminger
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx... Xie, Huawei
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx rou... Stephen Hemminger
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx... Xie, Huawei
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx rou... Stephen Hemminger
- [dpdk-dev] [PATCH v2 6/7] virtio: simple tx... Xie, Huawei