On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote:
> When rte_log.h was moved to a new directory, the include path was not
> updated for the generated C code produced by the pipeline library,
> which results in build failure for this code.
>
> Fixes: 09ce41310930 ("log: separate logging functions out of EAL")
> Cc: sta...@dpdk.org
>
Hi Cristian,
How can I verify the fix? Can you please list the required steps?
And I wonder how this skipped the testing, I guess v23.11 released with
this defect. Is there a gap in the CI or internal build/test scripts?
> Signed-off-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
> ---
> drivers/net/softnic/rte_eth_softnic_cli.c | 2 ++
> examples/pipeline/cli.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c
> b/drivers/net/softnic/rte_eth_softnic_cli.c
> index 085523fe03..95e705c553 100644
> --- a/drivers/net/softnic/rte_eth_softnic_cli.c
> +++ b/drivers/net/softnic/rte_eth_softnic_cli.c
> @@ -337,6 +337,7 @@ cmd_softnic_pipeline_libbuild(struct pmd_internals
> *softnic __rte_unused,
> "-I %s/lib/eal/include "
> "-I %s/lib/eal/x86/include "
> "-I %s/lib/eal/include/generic "
> + "-I %s/lib/log "
> "-I %s/lib/meter "
> "-I %s/lib/port "
> "-I %s/lib/table "
> @@ -361,6 +362,7 @@ cmd_softnic_pipeline_libbuild(struct pmd_internals
> *softnic __rte_unused,
> install_dir,
> install_dir,
> install_dir,
> + install_dir,
> log_file,
> obj_file,
> lib_file,
> diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
> index 2ae6cc579f..afb143c01f 100644
> --- a/examples/pipeline/cli.c
> +++ b/examples/pipeline/cli.c
> @@ -714,6 +714,7 @@ cmd_pipeline_libbuild(char **tokens,
> "-I %s/lib/eal/include "
> "-I %s/lib/eal/x86/include "
> "-I %s/lib/eal/include/generic "
> + "-I %s/lib/log "
> "-I %s/lib/meter "
> "-I %s/lib/port "
> "-I %s/lib/table "
> @@ -738,6 +739,7 @@ cmd_pipeline_libbuild(char **tokens,
> install_dir,
> install_dir,
> install_dir,
> + install_dir,
> log_file,
> obj_file,
> lib_file,
