Hello,
On Mon, Nov 23, 2020 at 8:08 AM Murphy Yang <murphyx.y...@intel.com> wrote:
>
> If enable hardware outer UDP TX offload checksum, it doesn't take effect
> when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
>
> In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT'
> equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware
> can calculate the outer tunneling UDP checksum.
>
> Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
>
> Signed-off-by: Murphy Yang <murphyx.y...@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> index 5fbd68eafc..9769e216bf 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
> *cd_tunneling |= (tx_offload.l2_len >> 1) <<
> ICE_TXD_CTX_QW0_NATLEN_S;
>
> - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
> - (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
> + /**
> + * Calculate the tunneling UDP checksum.
> + * Shall be set only if L4TUNT = 01b and EIPT is not zero
> + */
> + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
drivers/net/ice/base/ice_lan_tx_rx.h: ICE_TX_CTX_EIPT_NONE = 0x0,
So this check above is always true...
I suspect the intent was:
if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE)
> (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
> *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
> }
> --
> 2.17.1
>
--
David Marchand
