https://bugs.dpdk.org/show_bug.cgi?id=1409
Bug ID: 1409
Summary: arparse library assumes enum are 64 bit
Product: DPDK
Version: 24.03
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: dev@dpdk.org
Reporter: step...@networkplumber.org
Target Milestone: ---
MSVC correctly flags that this line in rte_argparse.h is incorrect:
RTE_ARGPARSE_ARG_RESERVED_FIELD = RTE_GENMASK64(63, 48),
The problem is that enum values are just an alias for int, and it can be 32
bits.
Taken from the current C Standard (C99):
http://www.open std.org/JTC1/SC22/WG14/www/docs/n1256.pdf
6.7.2.2 Enumeration specifiers
[...]
Constraints
The expression that defines the value of an enumeration constant shall be an
integer constant expression that has a value representable as an int.
[...]
Each enumerated type shall be compatible with char, a signed integer type, or
an unsigned integer type. The choice of type is implementation-defined, but
shall be capable of representing the values of all the members of the
enumeration.
Since rte_argparse only uses 10 bits now. The suggested fix here is to:
1. Assume 32 bits
2. Get rid of the reserved field - reserved fields are bad idea
--
You are receiving this mail because:
You are the assignee for the bug.
